Synchronized native AE calls to DLL #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbae
approved these changes
Jan 2, 2020
rene-ye
approved these changes
Jan 3, 2020
rene-ye
reviewed
Jan 6, 2020
| byte[] encryptedColumnEncryptionKey) throws DLLException; | ||
|
|
||
| static native boolean VerifyColumnMasterKeyMetadata(String keyPath, boolean allowEnclaveComputations, | ||
| static synchronized native boolean VerifyColumnMasterKeyMetadata(String keyPath, boolean allowEnclaveComputations, |
There was a problem hiding this comment.
Do both these functions call the same problematic handle getter? If so, don't we need to prevent both of them from calling the dll function at the same time? Might need an Object lock here instead of synchronized functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue when multiple threads calls AE methods