Fix inserting large spatial datatypes using setObject or setGeometry/setGeography #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprins
reviewed
May 18, 2020
src/test/java/com/microsoft/sqlserver/jdbc/datatypes/SQLServerSpatialDatatypeTest.java
Show resolved
Hide resolved
|
PR1337.zip |
|
@ulvii Thanks, I can/will give this a try at the end of the week at the earliest |
rene-ye
approved these changes
May 22, 2020
|
Hi @mprins, did you have a chance to test out the changes? |
|
I've ran 2 projects with this updated driver and all tests appear to be passing, including that reported in #1270 |
lilgreenbird
approved these changes
May 25, 2020
ulvii
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1270.
When the driver is inserting byte[] data into a column in the server's table, the driver changes the JdbcType of the column (effectively, we change what we send the data as in the INSERT query) if the byte array is larger than the 8000. For example, this means that if the driver was going to insert the data as geometry, it was instead sending varbinary(max) if the byte array that represents the geometry/geography data was larger than 8000. Excluding geometry/geography from being typecast into varbinary(max) solves this issue (geometry/geography data types don't have a size limit).