Support LocalDateTime and OffsetDateTime in CallableStatement #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CasualSuperman
force-pushed
the
callable-localdatetime
branch
2 times, most recently
from
5570d6c
to
03dcfee
Compare
|
Thanks @CasualSuperman for your contribution. The team will review this PR soon and let you know. |
This PR adds support for the requested functionality in microsoft#1392, but does not address the mentioned code duplication. The added library code was copied verbatim from SQLServerResultSet.
CasualSuperman
force-pushed
the
callable-localdatetime
branch
from
02212a5
to
e47fdeb
Compare
|
/azp run Microsoft.mssql-jdbc.windows |
ulvii
reviewed
Aug 26, 2020
src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableStatementTest.java
Outdated
Show resolved
Hide resolved
ulvii
reviewed
Aug 27, 2020
src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableStatementTest.java
Show resolved
Hide resolved
ulvii
reviewed
Aug 27, 2020
src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableStatementTest.java
Outdated
Show resolved
Hide resolved
peterbae
reviewed
Aug 27, 2020
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerCallableStatement.java
Show resolved
Hide resolved
|
Apologies for the multiple commits, I don't have a dev environment set up on this computer |
peterbae
approved these changes
Aug 28, 2020
|
The PR will require approvals from at least 3 of our team members, and we will merge it once they've approved. |
rene-ye
approved these changes
Aug 31, 2020
ulvii
approved these changes
Sep 1, 2020
|
Thanks for the contribution @CasualSuperman |
ulvii
changed the title
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the requested functionality in #1392, but does not address the mentioned code duplication.
The added library code was copied verbatim from
SQLServerResultSet.