Upgrading to new Key Vault (and MSAL) libraries #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed by default (microsoft#1254) * skip AKV test properly * removed enclave properties string to failed errors as enclave tests could be skipped
…sting has not been run yet.
… and remove try / catch in some test code where it is not required.
David-Engel
reviewed
Oct 6, 2020
There was a problem hiding this comment.
I just noticed we might be overlooking a scenario in the code changes:
https://github.com/microsoft/mssql-jdbc/pull/1413/files#diff-0a4455f5ffd8e31e9e1badaa7822375eL4454 (Old/Left line 4454 in SQLServerConnection.java)
MSAL should be able to cover the SqlAuthentication.ActiveDirectoryIntegrated scenario, right? Previously the driver had to rely on a native call (ultimately down to adal.dll) that I believe (hope) can now be accomplished via MSAL. We can then eliminate the underlying native call.
rene-ye
reviewed
Oct 6, 2020
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerColumnEncryptionAzureKeyVaultProvider.java
Outdated
Show resolved
Hide resolved
Added tests and catch exception from getKeyClient
added test for token credential and other cosmetic fixes
peterbae
previously approved these changes
Oct 10, 2020
add tenantID to pipeline and merged with dev
ulvii
reviewed
Oct 13, 2020
ulvii
reviewed
Oct 13, 2020
updated for MSAL
Fixed error msgs
ulvii
approved these changes
Oct 13, 2020
rene-ye
approved these changes
Oct 13, 2020
peterbae
approved these changes
Oct 13, 2020
lilgreenbird
approved these changes
Oct 13, 2020
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates from the previous-generation Azure Key Vault library and ADAL libraries to the more modern Azure Key Vault and MSAL equivalents.