Connection.getMetaData().getProcedures(String,String,String)) missing 9th column #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garydgregory
force-pushed
the
dbmetadata_GetProceduresResultSetMetaData_col9_missing
branch
from
73e98dd
to
9150e70
Compare
|
Hi @garydgregory, that sounds like a good fix. If you could add the changes to this PR, the team will review it. |
garydgregory
force-pushed
the
dbmetadata_GetProceduresResultSetMetaData_col9_missing
branch
from
9150e70
to
e1b6c5a
Compare
return 9 columns but is missing the 9th column called SPECIFIC_NAME. The issues is that the underlying server sp_stored_procedures() returns 8 columns while the API expects 9 columns. The driver passes the result set as is to the caller. This patch allows the JDBC getProcedures() API to add the missing column.
garydgregory
force-pushed
the
dbmetadata_GetProceduresResultSetMetaData_col9_missing
branch
from
e1b6c5a
to
4045815
Compare
garydgregory
changed the title
lilgreenbird
added
the
Enhancement
|
We have looked at this PR and have found that it does not work with the existing code base. We want to get this working but at this point we have not been able to dedicate the effort |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection.getMetaData().getProcedures(String,String,String)) should return 9 columns but is missing the 9th column SPECIFIC_NAME.
While the underlying server's stored procedure only returns 8 columns, the JDBC API must return the 9th to be compliant with the API even if the column values are null. This bug makes is harder to write JDBC code that is vendor neutral.
If you agree this is a bug, I can provide a fix.