Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes trustStorePassword set to null when using applicationIntent=ReadOnly #1565

Merged
merged 54 commits into from
Apr 26, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
c97b863
Fix AEv2 tests exclude for reqExternalSetup and cleanup (#1247)
lilgreenbird Feb 5, 2020
54b5a19
Fix | Add null check for getObject() with LocalTime and LocalDate (#1…
peterbae Feb 8, 2020
672b7d6
added all AKV tests to use reqExternalSetup tag so they will be skipp…
lilgreenbird Feb 10, 2020
3c3331b
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Mar 25, 2020
e2c5640
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Mar 26, 2020
aad6966
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Mar 28, 2020
92bf04c
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Mar 31, 2020
3ba5ab7
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Apr 4, 2020
d20823d
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Apr 7, 2020
4cc959f
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Apr 29, 2020
7b301f8
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Apr 30, 2020
56bcf13
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird May 7, 2020
744e0ca
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird May 12, 2020
df8fd41
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird May 19, 2020
652e68b
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird May 26, 2020
53736db
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird May 26, 2020
9ba6a42
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Jun 2, 2020
6d156f7
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Jun 5, 2020
e08ffe5
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Jun 10, 2020
6b6cab2
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Jun 18, 2020
c202590
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Jun 24, 2020
0515d4b
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Jun 24, 2020
2c63b58
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Jun 25, 2020
78aa941
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Jul 2, 2020
90e99cd
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Jul 2, 2020
da1004b
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Jul 6, 2020
9ca1284
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Jul 28, 2020
c67d8ed
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Aug 1, 2020
1d0a4ad
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Aug 5, 2020
f1b1dfb
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Aug 26, 2020
d9bad87
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Sep 2, 2020
a2e50b9
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Sep 9, 2020
7ff97de
enable ADintegrated tests for non-windows
lilgreenbird Sep 9, 2020
7cae3b4
fixed user test for kerberos
lilgreenbird Sep 11, 2020
c8c5a29
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Sep 16, 2020
d76368a
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Sep 22, 2020
e5aafd3
Merge branch 'dev' of https://github.com/lilgreenbird/mssql-jdbc into…
lilgreenbird Sep 22, 2020
7800824
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Oct 5, 2020
a8199bb
merged
lilgreenbird Oct 14, 2020
3a91ea1
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Oct 16, 2020
3e39be1
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Oct 28, 2020
16d2bbd
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Nov 28, 2020
f9d22e9
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Dec 2, 2020
8eeb9a6
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Dec 8, 2020
465219f
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Jan 8, 2021
dc836d0
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Jan 12, 2021
0c9a08c
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Jan 13, 2021
ab9b2f2
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Feb 11, 2021
370cf6c
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Feb 24, 2021
dfbdaec
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Mar 19, 2021
0933a4f
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird Apr 8, 2021
0041c40
clear password
lilgreenbird Apr 15, 2021
a472328
fix
lilgreenbird Apr 22, 2021
45139b6
formatting
lilgreenbird Apr 22, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/main/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
Original file line number Diff line number Diff line change
Expand Up @@ -1734,10 +1734,6 @@ else if (con.getTrustManagerClass() != null) {
try {
ks.load(is, (null == trustStorePassword) ? null : trustStorePassword.toCharArray());
} finally {
// We are done with the trustStorePassword (if set). Clear it for better security.
con.activeConnectionProperties
.remove(SQLServerDriverStringProperty.TRUST_STORE_PASSWORD.toString());

// We are also done with the trust store input stream.
if (null != is) {
try {
Expand Down Expand Up @@ -4029,8 +4025,7 @@ void writeNonUnicodeReader(Reader reader, long advertisedLength, boolean isDestB

do {
// Read in next chunk
for (charsToWrite = 0; -1 != charsRead && charsToWrite < currentPacketSize;
charsToWrite += charsRead) {
for (charsToWrite = 0; -1 != charsRead && charsToWrite < currentPacketSize; charsToWrite += charsRead) {
try {
charsRead = reader.read(streamCharBuffer, charsToWrite, currentPacketSize - charsToWrite);
} catch (IOException e) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2355,6 +2355,8 @@ else if (0 == requestedPacketSize)
if (!state.equals(State.Closed))
this.close();
}

activeConnectionProperties.remove(SQLServerDriverStringProperty.TRUST_STORE_PASSWORD.toString());
}

return this;
Expand Down