Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lobs tests #168

Merged
merged 5 commits into from
Mar 10, 2017
Merged

Lobs tests #168

merged 5 commits into from
Mar 10, 2017

Conversation

AfsanehR-zz
Copy link
Contributor

test framework update for lobs tests

@codecov-io
Copy link

codecov-io commented Mar 4, 2017

Codecov Report

Merging #168 into dev will increase coverage by 1.45%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##               dev     #168      +/-   ##
===========================================
+ Coverage     29.7%   31.15%   +1.45%     
- Complexity    1248     1322      +74     
===========================================
  Files           97       97              
  Lines        23305    23305              
  Branches      3871     3871              
===========================================
+ Hits          6923     7261     +338     
+ Misses       15028    14566     -462     
- Partials      1354     1478     +124
Flag Coverage Δ Complexity Δ
#JDBC41 31.07% <ø> (+1.46%) 1317 <ø> (+72)
#JDBC42 31.07% <ø> (+1.48%) 1321 <ø> (+77)
Impacted Files Coverage Δ Complexity Δ
src/main/java/microsoft/sql/DateTimeOffset.java 37.14% <0%> (-2.86%) 8% <0%> (-2%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 45.89% <0%> (+0.07%) 183% <0%> (+1%)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 38.47% <0%> (+0.23%) 50% <0%> (ø)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 39.17% <0%> (+0.39%) 193% <0%> (+3%)
...ava/com/microsoft/sqlserver/jdbc/SQLCollation.java 92.49% <0%> (+0.48%) 12% <0%> (+1%)
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 68.85% <0%> (+0.84%) 2% <0%> (+2%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 23.88% <0%> (+0.89%) 39% <0%> (+3%)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 20.17% <0%> (+1.16%) 54% <0%> (+3%)
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 32.54% <0%> (+1.18%) 22% <0%> (+1%)
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 39.7% <0%> (+1.47%) 10% <0%> (+1%)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 369e5e0...4d6baa0. Read the comment docs.

generatePrecision();
}

/**
* create random data for binary and varbinary column
*/
public Object createdata() {
int dataLength = ThreadLocalRandom.current().nextInt(precision);
int dataLength = ThreadLocalRandom.current().nextInt(5);// precision
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add precision instead of 5

* @return
* @throws Exception
*/
public boolean canconvert(Class target,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method name should be CamelCase

@v-nisidh
Copy link
Contributor

Linking more test cases for Issue #16

@v-nisidh v-nisidh merged commit 171c8e8 into microsoft:dev Mar 10, 2017
@lilgreenbird lilgreenbird added this to Closed/Merged PRs in MSSQL JDBC Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

3 participants