Enable cname resolution when realm is specified in connection #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not too familiar with the code, but wasn't there a mention of a test update required or was it an addition of a new test? |
src/main/java/com/microsoft/sqlserver/jdbc/SSPIAuthentication.java
Outdated
Show resolved
Hide resolved
|
I'm not too familiar with the project, but I didn't find any existing test cases for Kerberos authentication or this method. Are there any test cases that could be extended to facilitate a new test case without breaking existing test capabilities? |
tkyc
approved these changes
Jan 18, 2022
lilgreenbird
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #1688 with additional logging and running formatter.