Cache Parameter Metadata #1845
Merged
Cache Parameter Metadata #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ft/mssql-jdbc into cache-parameter-metadata
tkyc
reviewed
Jun 15, 2022
src/test/java/com/microsoft/sqlserver/jdbc/parametermetadata/ParameterMetaDataCacheTest.java
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLQueryMetadataCache.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLQueryMetadataCache.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLQueryMetadataCache.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLQueryMetadataCache.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/parametermetadata/ParameterMetaDataCacheTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/parametermetadata/ParameterMetaDataCacheTest.java
Outdated
Show resolved
Hide resolved
…p to ConcurrentHashMap
…r on test setup method.
src/main/java/com/microsoft/sqlserver/jdbc/SQLQueryMetadataCache.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLQueryMetadataCache.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/ISQLServerEnclaveProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLQueryMetadataCache.java
Outdated
Show resolved
Hide resolved
| * @return true, if the metadata for the query can be retrieved | ||
| * | ||
| */ | ||
| static boolean getQueryMetadata(Parameter[] params, ArrayList<String> parameterNames, |
There was a problem hiding this comment.
we don't need all these static methods this takes up memory. The caller should create an instance of the cache and invoke the methods
src/main/java/com/microsoft/sqlserver/jdbc/SQLQueryMetadataCache.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLQueryMetadataCache.java
Outdated
Show resolved
Hide resolved
… alongside the error code.
lilgreenbird
previously approved these changes
Jun 21, 2022
…s problems, test will still correctly assess the error code path in ParameterMetaDataCache
Jeffery-Wasty
dismissed stale reviews from David-Engel and lilgreenbird
via
345ef9f
tkyc
previously approved these changes
Jun 21, 2022
lilgreenbird
previously approved these changes
Jun 21, 2022
tkyc
approved these changes
Jun 22, 2022
VeryVerySpicy
approved these changes
Jun 22, 2022
lilgreenbird
approved these changes
Jun 22, 2022
|
@Jeffery-Wasty this is an exciting change! Thank you for working on it!
|
|
Hi @alex-bochkov, We'll be releasing documentation regarding new features shortly, in the meantime I can answer the questions you have included: 1. What's the cache TTL? The cache doesn't have an independent TTL, rather the enclave session it belongs to has a TTL of eight hours. 2. Is it possible to disable cache if needed? For example, if we need to make schema changes and make sure the app won't break in the middle. It's not possible to disable the cache at the moment. This is something we can potentially add a later time, however current efforts are towards extending caching for secure enclave scenarios. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache sp_describe_parameter_encryption calls to improved performance by reducing trips to the server. For now, supports AE without secure enclaves, with enclave support (v3) to be added in a later update.