Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataclassification sensitivity max index fix #1847

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Dataclassification sensitivity max index fix #1847

merged 2 commits into from
Jun 22, 2022

Conversation

tkyc
Copy link
Member

@tkyc tkyc commented Jun 21, 2022

Both SensitivityLabelIndex and InformationTypeIndex have a max of USHORT_MAX as defined in the TDS spec, and not a max of INTEGER_MAX

@lilgreenbird lilgreenbird added this to In progress in MSSQL JDBC via automation Jun 21, 2022
@lilgreenbird lilgreenbird added this to the 11.1.2 milestone Jun 21, 2022
@lilgreenbird lilgreenbird moved this from In progress to Under Peer Review in MSSQL JDBC Jun 21, 2022
@lilgreenbird lilgreenbird merged commit c9f955f into microsoft:main Jun 22, 2022
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Jun 22, 2022
@tkyc tkyc deleted the dataclassification-max-indexes-fix branch November 16, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilgreenbird lilgreenbird lilgreenbird approved these changes

@Jeffery-Wasty Jeffery-Wasty Jeffery-Wasty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Milestone
11.1.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tkyc @lilgreenbird @Jeffery-Wasty