Fixed Idle Connection recovery so that unprocessedResponseCount isn't over decremented #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkyc
commented
Dec 5, 2022
lilgreenbird
changed the title
lilgreenbird
reviewed
Dec 6, 2022
src/test/java/com/microsoft/sqlserver/jdbc/resiliency/BasicConnectionTest.java
Outdated
Show resolved
Hide resolved
tkyc
force-pushed
the
ICR-unprocessed-reponse-count-fix
branch
from
5fca34a
to
7f170e0
Compare
lilgreenbird
previously approved these changes
Dec 13, 2022
Jeffery-Wasty
previously approved these changes
Dec 13, 2022
tkyc
dismissed stale reviews from Jeffery-Wasty and lilgreenbird
via
2cc15e5
Jeffery-Wasty
approved these changes
Dec 13, 2022
lilgreenbird
approved these changes
Dec 13, 2022
tkyc
added a commit
that referenced
this pull request
Dec 14, 2022
… over decremented (#1989) * Updated onDone with reason/comment for unecessary decrement for future reference * Added more ICR tests * Added missing brackets * Test table names needed to be unique * Drop tables within test if exist Co-authored-by: lilgreenbird <v-susanh@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
unprocessedResponseCountneeds to be decremented only whendoneToken.isFinalis true.Fixes #1971 also.