Upgrade to the latest OSGi JDBC specification

[laeubi]

In the latest release of the JDBC specification there was a requirement added that datasources should promote what methods they implement. mssql-jdbc implements all methods and could therefore promote all.

This also migrates from the org.osgi.enterprise artifact to the more specific org.osgi.service.jdbc one and adds the official TCK test as part of the JUnit-Suite.

FYI @stbischof

[stbischof]

Thank you for adding the properties and covering it bY osgi tck

[Jeffery-Wasty]

Hi @laeubi,

We'll look into this, confirm whether these are all the changes we need to make spec, and get back to you. Thank you for your contribution.

[Jeffery-Wasty]

Hi @laeubi,

I'm unable to find the specification you're referring to. Do you happen to have a link?

[laeubi]

@Jeffery-Wasty no problem the specification is located here:

https://docs.osgi.org/specification/osgi.cmpn/8.1.0/service.jdbc.html

previous version(s):
https://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.jdbc.html
https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.jdbc.html

[Jeffery-Wasty]

I see that OSGI compendium on maven has migrated to here: https://mvnrepository.com/artifact/org.osgi/osgi.cmpn, which is probably why we're still using version 5. We missed that the page had changed. However, this page only has up to version 7, is there a maven repository for compendium 8?

[laeubi]

R8 do not has a "fat compendium jar" anymore but many small dedicated items and therefore uses

<dependency>
  <groupId>org.osgi</groupId>
  <artifactId>org.osgi.service.jdbc</artifactId>
  <version>${osgi.jdbc.version}</version>
  <scope>provided</scope>
</dependency>

now.

[Jeffery-Wasty]

I see, thank you. And thanks for the quick reply!

[Jeffery-Wasty]

Hi @laeubi,

The dependency changes are causing test failures, as seen below, coming from the org.eclipse.osgi dependency. I don't see this as a dependency of org.osgi.service.jdbc, what is this needed for?

[laeubi]

@Jeffery-Wasty I'll try to take a look the next days, I think I might perform the upgrade in smaller steps to see whats going on here...

[laeubi]

@Jeffery-Wasty I have now started with a very minimal change, that just upgrades to the new artifact location from central:

• Move from compendium to jdbc spec artifact #2064

It would be great if you can take a look, probably this could even be merged already as a first step.

[laeubi]

I created another one that do the actual code changes here:

• Upgrade osgi jdbc spec add properties #2065

with those it should be possible to see if that alone causes any issues

[laeubi]

And finally we have the test execution added here:

• Upgrade osgi jdbc add tck #2066

[Jeffery-Wasty]

Thanks @laeubi, we'll take a look at each of the PRs you have linked.

[Jeffery-Wasty]

As stated in #2066, lets use this as the sole PR. If you're able to fix the test to not use Junit5 it can be included, otherwise we'll move forward without it.

[laeubi]

I fear the test requires JUnit5

[laeubi]

My only idea is that one probabbly can create a new module that only contains this single test ... but the repo seems not really a multi-module one... so for now then we should go without the test.

[Jeffery-Wasty]

I see, thank you for looking into this. If we end up being able to use Junit5 moving forward, we can revisit adding the test on, its always good to have additional testing. For now, if we can ask you to push a commit removing the test, we can review the PR and get it merged.

[laeubi]

Now everything should be cleaned up and rebased