Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bigDecimal values between 0 and 1 having too high of a precision #2116

Merged
merged 19 commits into from
May 4, 2023

Conversation

Jeffery-Wasty
Copy link
Member

@Jeffery-Wasty Jeffery-Wasty commented May 1, 2023

Changes how precision and scaling are computed for bigDecimal values to account for a big where precision is 1 too high for numbers between 0 and 1.

@Jeffery-Wasty Jeffery-Wasty changed the title Fix for numbers between 0 and 1. Fix for bigDecimal values between 0 and 1 having too high of a precision May 2, 2023
@Jeffery-Wasty Jeffery-Wasty linked an issue May 2, 2023 that may be closed by this pull request
@Jeffery-Wasty Jeffery-Wasty added the Under Review Used for pull requests under review label May 2, 2023
@Jeffery-Wasty Jeffery-Wasty added this to In progress in MSSQL JDBC via automation May 2, 2023
@Jeffery-Wasty Jeffery-Wasty moved this from In progress to Under Peer Review in MSSQL JDBC May 2, 2023
@Jeffery-Wasty Jeffery-Wasty added this to the 12.3.0 milestone May 2, 2023
@Jeffery-Wasty Jeffery-Wasty merged commit e373323 into main May 4, 2023
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs May 4, 2023
@Jeffery-Wasty Jeffery-Wasty deleted the bigDecimalLessThan1Fix branch May 4, 2023 19:59
@Jeffery-Wasty Jeffery-Wasty removed the Under Review Used for pull requests under review label May 4, 2023
tkyc pushed a commit that referenced this pull request Jul 26, 2023
…es between 0 and 1 having too high of a precision) (#2176)

* Revert big decimal changes

* Delete TestClass.java

* Delete RetryLogicProvider.java

* Update Parameter.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

Wrong precision for BigDecimal < 0 (since #2051)
2 participants