add useDefaultGSSCredential property #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
tkyc
reviewed
Sep 27, 2023
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
|
Looks good to me now. This PR is good to go for merging. This will be available in the next major release which is scheduled in the new year. |
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerResource.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/ISQLServerDataSource.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
Jeffery-Wasty
previously approved these changes
Oct 11, 2023
…ource Co-authored-by: Jeffery Wasty <v-jeffwasty@microsoft.com>
Co-authored-by: Jeffery Wasty <v-jeffwasty@microsoft.com>
tkyc
force-pushed
the
useDefaultGssCredential/2172
branch
from
cc13d15
to
51ebf4e
Compare
Jeffery-Wasty
approved these changes
Oct 11, 2023
Jeffery-Wasty
previously approved these changes
Oct 11, 2023
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
lilgreenbird
approved these changes
Oct 12, 2023
Jeffery-Wasty
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal Pull Request for Issue #2172
useDefaultGSSCredential: Boolean - by setting this property to true, mssql-jdbc will create the GSSCredential on behalf of user using Native GSS-API for kerberos authentication without attempting to perform JAAS login.
This will allow seamless integration with framework that only supports String value connection Properties such as Apache Spark
This property currently take effect only in a window. I currently don't have access to a Kerberzied Linux environment to test this. However, I supposed we could make this work on all platforms.