Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added automatic spacing between parameter names for prepared statements #2192

Merged
merged 4 commits into from
Aug 16, 2023

Conversation

tkyc
Copy link
Member

@tkyc tkyc commented Aug 12, 2023

Parameter names eg. P1, P2, ... PN will have spaces applied automatically between them.

When the driver parses select * from table where a=?and b=? it will become select * from table where a= ? and b= ? .

@tkyc tkyc added this to the 12.4.1 milestone Aug 12, 2023
Jeffery-Wasty
Jeffery-Wasty previously approved these changes Aug 14, 2023
@Jeffery-Wasty Jeffery-Wasty added this to In progress in MSSQL JDBC via automation Aug 14, 2023
@Jeffery-Wasty Jeffery-Wasty moved this from In progress to Under Peer Review in MSSQL JDBC Aug 14, 2023
MSSQL JDBC automation moved this from Under Peer Review to In progress Aug 15, 2023
@tkyc tkyc merged commit 6b2bc00 into main Aug 16, 2023
17 checks passed
MSSQL JDBC automation moved this from In progress to Closed/Merged PRs Aug 16, 2023
@tkyc tkyc deleted the param-spacing branch August 16, 2023 16:58
tkyc added a commit that referenced this pull request Aug 17, 2023
…ts (#2192)

* Added spacing for parameter names for preparedStmts

* Added test for param spacing change

* Removed duplicate/similar method

* Changed method names to be more descriptive
tkyc added a commit that referenced this pull request Aug 17, 2023
…ts (#2192) (#2196)

* Added spacing for parameter names for preparedStmts

* Added test for param spacing change

* Removed duplicate/similar method

* Changed method names to be more descriptive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

3 participants