Fix to allow connection retries to be disabled by setting connectRetryCount to 0

[lilgreenbird]

No description provided.

[tkyc]

I did a quick test and I see that it's retrying twice.

FINER: ConnectionID:1 Connection open - connection failed on attempt: 0.
Jan 18, 2024 9:56:19 A.M. com.microsoft.sqlserver.jdbc.SQLServerConnection login
FINER: ConnectionID:1 Connection open - connection failure. Driver error code: 0
Jan 18, 2024 9:56:19 A.M. com.microsoft.sqlserver.jdbc.SQLServerConnection login
FINER: ConnectionID:1 Connection open - sleeping milisec: 10
Jan 18, 2024 9:56:19 A.M. com.microsoft.sqlserver.jdbc.SQLServerConnection login
FINER: ConnectionID:1 Connection open - connection failed on transient error . Wait for connectRetryInterval(10)s before retry #0
Jan 18, 2024 9:56:19 A.M. com.microsoft.sqlserver.jdbc.SQLServerConnection login
FINE: ConnectionID:1 Connection open - connection retry failed on attempt number: 1
Jan 18, 2024 9:56:19 A.M. com.microsoft.sqlserver.jdbc.SQLServerConnection login
FINER: ConnectionID:1 Connection open - connection failed. Maximum connection retry count 0 reached.

Repro app

        String connectionUrl = "jdbc:sqlserver://sqlao1vm1.availability.local\\DEVINSTANCE;connectRetryCount=0;trustServerCertificate=true;databaseName=master;IntegratedSecurity=true;authenticationScheme=NTLM;user=;password=;domain=availability.local;";

        Handler fh = new ConsoleHandler();
        fh.setFormatter(new SimpleFormatter());
        fh.setLevel(Level.FINER);
        Logger.getLogger("").addHandler(fh);
        Logger logger = Logger.getLogger("com.microsoft.sqlserver.jdbc.Resiliency");
        logger.setLevel(Level.FINEST);

        try (Connection con = DriverManager.getConnection(connectionUrl); Statement stmt = con.createStatement();) {
            String SQL = "SELECT GETDATE() as dt";
            ResultSet rs = stmt.executeQuery(SQL);
            // Iterate through the data in the result set and display it.
            while (rs.next()) {
                System.out.println(rs.getString("dt"));
            }
        }

        // Handle any errors that may have occurred.
        catch (SQLException e) {
            e.printStackTrace();
        }

EDIT: Nevermind, it should be twice when TNIR=true.

[codecov]

Codecov Report

Attention: Patch coverage is 55.26316% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 50.04%. Comparing base (cfb018a) to head (0622787).

❗ Current head 0622787 differs from pull request most recent head fc20b85. Consider uploading reports for the commit fc20b85 to get more accurate results

Files	Patch %	Lines
.../microsoft/sqlserver/jdbc/SQLServerConnection.java	56.25%	7 Missing and 7 partials ⚠️
...m/microsoft/sqlserver/jdbc/SQLServerException.java	50.00%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##               main    #2293       +/-   ##
=============================================
- Coverage     73.60%   50.04%   -23.56%     
+ Complexity     6082     3786     -2296     
=============================================
  Files           142      143        +1     
  Lines         33123    33128        +5     
  Branches       5623     5628        +5     
=============================================
- Hits          24380    16579     -7801     
- Misses         6234    14171     +7937     
+ Partials       2509     2378      -131     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.