Re-added support for stored procedure 'exec' escape syntax in CallableStatements #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilgreenbird
reviewed
Feb 9, 2024
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerPreparedStatement.java
Outdated
Show resolved
Hide resolved
lilgreenbird
reviewed
Feb 9, 2024
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerPreparedStatement.java
Outdated
Show resolved
Hide resolved
lilgreenbird
reviewed
Feb 9, 2024
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerPreparedStatement.java
Outdated
Show resolved
Hide resolved
lilgreenbird
reviewed
Feb 9, 2024
src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableStatementTest.java
Outdated
Show resolved
Hide resolved
lilgreenbird
reviewed
Feb 9, 2024
src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableStatementTest.java
Show resolved
Hide resolved
lilgreenbird
reviewed
Feb 9, 2024
src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableStatementTest.java
Outdated
Show resolved
Hide resolved
lilgreenbird
previously approved these changes
Feb 9, 2024
David-Engel
reviewed
Feb 9, 2024
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerPreparedStatement.java
Outdated
Show resolved
Hide resolved
tkyc
changed the title
David-Engel
previously approved these changes
Feb 13, 2024
lilgreenbird
approved these changes
Feb 14, 2024
Jeffery-Wasty
approved these changes
Feb 14, 2024
tkyc
added a commit
that referenced
this pull request
Feb 15, 2024
…eStatements (#2325) * EXEC system stored procedure regression fix * Additional test * Additional test * Indenting * Switched error string to TestResource error string * CR comments * Test update p1 * Test update p2 * CR comment changes; Test update * call escape syntax check * CR changes * formatting
tkyc
added a commit
that referenced
this pull request
Feb 17, 2024
…eStatements (#2325) (#2329) * EXEC system stored procedure regression fix * Additional test * Additional test * Indenting * Switched error string to TestResource error string * CR comments * Test update p1 * Test update p2 * CR comment changes; Test update * call escape syntax check * CR changes * formatting
|
@olerabanal #2329 is the backport of this PR to 12.6, which is in the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to 12.6.0, all cstmts calls were wrapped int T-SQL sp_executesql, sp_prepexec etc.. calls before being sent off to the server. Doing so means the raw/unprocessed user's sql was passed into these T-SQL calls as parameter values and so the driver was able to execute "EXEC" calls against the server eg.
EXEC sp_columns_100 ?,?,?,?.....For example:
This PR enables this prior behaviour again.
#2323