Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calling procedures with output parameters by their four-part syntax #2349

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

tkyc
Copy link
Member

@tkyc tkyc commented Mar 18, 2024

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.99%. Comparing base (eae6d7b) to head (55554b6).
Report is 1 commits behind head on main.

❗ Current head 55554b6 differs from pull request most recent head 70c0a36. Consider uploading reports for the commit 70c0a36 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2349       +/-   ##
=============================================
- Coverage     73.56%   49.99%   -23.57%     
+ Complexity     6079     3789     -2290     
=============================================
  Files           143      143               
  Lines         33179    33189       +10     
  Branches       5631     5631               
=============================================
- Hits          24407    16594     -7813     
- Misses         6255    14214     +7959     
+ Partials       2517     2381      -136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jeffery-Wasty Jeffery-Wasty added this to In progress in MSSQL JDBC via automation Mar 18, 2024
@Jeffery-Wasty Jeffery-Wasty moved this from In progress to Under Peer Review in MSSQL JDBC Mar 18, 2024
@Jeffery-Wasty Jeffery-Wasty added this to the 12.6.2 milestone Mar 18, 2024
@Jeffery-Wasty Jeffery-Wasty modified the milestones: 12.6.2, 12.7.0 Mar 19, 2024
@barryw-mssql barryw-mssql self-requested a review March 19, 2024 20:51
@tkyc tkyc merged commit aa46637 into main Mar 19, 2024
22 checks passed
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Mar 19, 2024
@tkyc tkyc deleted the four-part-syntax-fix branch March 19, 2024 22:35
@Jeffery-Wasty Jeffery-Wasty added this to To Backport in 12.6.2 Hotfix Apr 5, 2024
@Jeffery-Wasty Jeffery-Wasty moved this from To Backport to Completed in 12.6.2 Hotfix May 16, 2024
@Jeffery-Wasty Jeffery-Wasty moved this from Completed to To Backport in 12.6.2 Hotfix May 16, 2024
@Jeffery-Wasty Jeffery-Wasty moved this from To Backport to Completed in 12.6.2 Hotfix May 16, 2024
@Jeffery-Wasty Jeffery-Wasty moved this from Completed to To Backport in 12.6.2 Hotfix May 17, 2024
@Jeffery-Wasty Jeffery-Wasty removed this from To Backport in 12.6.2 Hotfix May 17, 2024
tkyc added a commit that referenced this pull request May 22, 2024
…ax (#2349)

* Corrected four part syntax regression

* JDK 8 correction
Jeffery-Wasty pushed a commit that referenced this pull request May 22, 2024
…2427)

* Fix calling procedures with output parameters by their four-part syntax (#2349)

* Corrected four part syntax regression

* JDK 8 correction

* Execute stored procedures directly for RPC calls (#2410)

* RPC fix

* Assertion index correction

* Removed magic number

* Removed login drop command

* Code review changes

* Formatting

* Test config changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

12.6.x has broken the ability to call procedures with output parameters by their four-part syntax
3 participants