New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that money/small money are within correct range for bulkcopy #2379

Merged

Jeffery-Wasty merged 5 commits into main from moneySmallMoneyFix

Apr 4, 2024

Member

Jeffery-Wasty commented Apr 3, 2024

Fixes #2309


          Fixed 2309

576f53e

Jeffery-Wasty added this to In progress in MSSQL JDBC via automation

codecov bot commented Apr 3, 2024 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.23%. Comparing base (78bdefd) to head (7ee5be8).

❗ Current head 7ee5be8 differs from pull request most recent head 13fb1df. Consider uploading reports for the commit 13fb1df to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2379      +/-   ##
============================================
+ Coverage     50.21%   50.23%   +0.02%     
- Complexity     3841     3848       +7     
============================================
  Files           145      145              
  Lines         33358    33360       +2     
  Branches       5654     5654              
============================================
+ Hits          16750    16759       +9     
+ Misses        14221    14211      -10     
- Partials       2387     2390       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lilgreenbird added this to the 12.7.0 milestone

Jeffery-Wasty marked this pull request as ready for review

April 4, 2024 17:35

Jeffery-Wasty requested review from lilgreenbird, tkyc and barryw-mssql

April 4, 2024 17:35


          CHANGELOG fix

d0c15e8

Jeffery-Wasty moved this from In progress to Under Peer Review in MSSQL JDBC

tkyc reviewed

View reviewed changes

src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyMoneyTest.java Show resolved Hide resolved

lilgreenbird reviewed

View reviewed changes

src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyMoneyTest.java Outdated Show resolved Hide resolved

lilgreenbird reviewed

View reviewed changes

src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyMoneyTest.java Outdated Show resolved Hide resolved

lilgreenbird reviewed

View reviewed changes

src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyMoneyTest.java Outdated Show resolved Hide resolved

lilgreenbird reviewed

View reviewed changes

src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyMoneyTest.java Outdated Show resolved Hide resolved

barryw-mssql previously approved these changes

View reviewed changes

lilgreenbird reviewed

View reviewed changes

src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyMoneyTest.java Outdated Show resolved Hide resolved

lilgreenbird reviewed

View reviewed changes

src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyMoneyTest.java Outdated Show resolved Hide resolved


          Review fixes

70812b9

lilgreenbird reviewed

View reviewed changes

src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyMoneyTest.java Outdated Show resolved Hide resolved

Jeffery-Wasty dismissed barryw-mssql’s stale review via

70812b9

April 4, 2024 18:04

MSSQL JDBC automation moved this from Under Peer Review to In progress

lilgreenbird previously requested changes

View reviewed changes

Member

lilgreenbird left a comment

please run formatter


          More review + format

fa906bb

tkyc previously approved these changes

View reviewed changes

Jeffery-Wasty requested a review from lilgreenbird

April 4, 2024 18:18

Jeffery-Wasty dismissed lilgreenbird’s stale review

April 4, 2024 18:19

Addressed


          More changes

13fb1df

Jeffery-Wasty dismissed tkyc’s stale review via

13fb1df

April 4, 2024 18:28

lilgreenbird approved these changes

View reviewed changes

tkyc approved these changes

View reviewed changes

barryw-mssql approved these changes

View reviewed changes

Jeffery-Wasty merged commit 5b3f32e into main

3 of 17 checks passed

MSSQL JDBC automation moved this from In progress to Closed/Merged PRs

Jeffery-Wasty deleted the moneySmallMoneyFix branch

April 4, 2024 21:35

Jeffery-Wasty added this to To Backport in 12.6.2 Hotfix

Jeffery-Wasty added a commit that referenced this pull request


          Changes to MONEY/SMALLMONEY PR (#2379) (#2383)

67f7fab

* Changes as per prior code review

* setupMoneyTests can be added to beforeAll, it should be ran each time

* Passed in wrong values for tests

Jeffery-Wasty mentioned this pull request

[Backport] Check that money/small money are within correct range for bulkcopy (2379) & Changes to MONEY/SMALLMONEY PR (2383) #2419

Merged

Jeffery-Wasty removed this from To Backport in 12.6.2 Hotfix

tkyc added a commit that referenced this pull request


          Revert "Check that money/small money are within correct range for bul…

a251fdc

…kcopy (#2379)"

This reverts commit 5b3f32e.

tkyc added a commit that referenced this pull request


          Revert "Changes to MONEY/SMALLMONEY PR (#2379) (#2383)"

3aa370b

This reverts commit 67f7fab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment