Skip to content

Commit

Permalink
Pkg config, nbinit and other fixes (#62)
Browse files Browse the repository at this point in the history
* Readthedocs link has changed

* Updated pkg_config to add DataProviders section to config. AzureCLI and AzureSentinel sections are copied into this section. This allows Key Vault protection of the keys and use of Env Vars, etc.

Timeline - fixed Tooltip representation of Timestamps for different representations of numpy's types
Fixed an error in test-pypi-test-pkg.cmd
Added two Logon fail queries for linux
Added nbinit.py notebook initialization.

* Fix to utility.py - check_and_install_missing_packages.

nbinit.py - adding docstring and tidying code
ip_utils.py - added populate_host_entity, changing get_whois_df to use tqdm
msticpyconfig.yaml - fixing incorrect KeyVault setting

* Change return type on for bokeh graphs to return whole layout

Improved geoip error messages when Api key is missing
Fixing bug in pkg_config if no workspaces are defined (empty workspaces key)

* Removing populate_host_entity - added to notebooklets nblib

* Fixing a few linting and test errors.

* Removing unneeded import from ip_utils

Correcting spelling of seaborn in mypy.ini

* Adding test cell to debug build-time test

* Test version of GeoIPLookups.ipynb

Updating version number

* Fixing error in NB test code

* Fixing test_azuredata.py

Fixing (again) test code in GeoIPLookups.ipynb

* Fixing GeoIPLookups.ipynb test case - the fix was in other tests.

Added context manager to temporarily set msticpyconfig to another path and auto-revert settings afterwards.
Updated affected tests to use context manager and library-based test_path function.

* Updating pylintrc to have looser limits for some checks.

* Fixing some items from code review.

Corrected some errors in MorphCharts.rst

* Mistake in my fix for validation in pkg_config.py

Suppressing import beyond top level warning in unit_test_lib.py

* Credscan suppression for msticpyconfig.rst
  • Loading branch information
ianhelle committed May 8, 2020
1 parent 8763f40 commit 9a28ea1
Show file tree
Hide file tree
Showing 36 changed files with 1,224 additions and 656 deletions.
4 changes: 4 additions & 0 deletions .ci_config/credscan.json
Expand Up @@ -8,6 +8,10 @@
{
"file": "AzureData.rst.txt",
"_justification": "This is code usage example and does not contain a secret."
},
{
"file": "msticpyconfig.rst.txt",
"_justification": "This is code usage example and does not contain a secret."
}
]
}
2 changes: 2 additions & 0 deletions .gitignore
Expand Up @@ -113,3 +113,5 @@ venv.bak/
#MorphChart test output
morphchart_package/

# Merge conflict files
**.orig
6 changes: 3 additions & 3 deletions .pylintrc
Expand Up @@ -491,10 +491,10 @@ valid-metaclass-classmethod-first-arg=cls
[DESIGN]

# Maximum number of arguments for function / method.
max-args=5
max-args=7

# Maximum number of attributes for a class (see R0902).
max-attributes=7
max-attributes=10

# Maximum number of boolean expressions in an if statement.
max-bool-expr=5
Expand All @@ -518,7 +518,7 @@ max-returns=6
max-statements=50

# Minimum number of public methods for a class (see R0903).
min-public-methods=2
min-public-methods=1


[IMPORTS]
Expand Down

0 comments on commit 9a28ea1

Please sign in to comment.