Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSTICPy config should support Azure cloud config #192

Closed
ianhelle opened this issue Aug 5, 2021 · 0 comments · Fixed by #193
Closed

MSTICPy config should support Azure cloud config #192

ianhelle opened this issue Aug 5, 2021 · 0 comments · Fixed by #193
Assignees
@ianhelle
Labels
accepted The request/issue is accepted for a fix bug Something isn't working enhancement New feature or request

Comments

@ianhelle
Copy link
Contributor

ianhelle commented Aug 5, 2021

Describe the bug
Currently MSTICPy is mostly ignorant of Azure cloud environment. A number of components require authentication to cloud-specific AAD endpoints.

To Reproduce
Steps to reproduce the behavior:

  1. Load an MSTICPy notebook
  2. Configure workspace/tenant for an Azure gov cloud workspace
  3. Try to authenticate
  4. It will default to the public cloud and the authentication will fail

Expected behavior
We need a single point to configure Azure cloud setting. All relevant components should take this config item when authenticating and performing other operations.

Screenshots
If applicable, add screenshots to help explain your problem.
@ianhelle ianhelle self-assigned this Aug 5, 2021
@ianhelle ianhelle added accepted The request/issue is accepted for a fix bug Something isn't working enhancement New feature or request labels Aug 5, 2021
@ianhelle ianhelle linked a pull request Sep 2, 2021 that will close this issue
Adding support for multiple Azure Clouds #193
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianhelle ianhelle

Labels
accepted The request/issue is accepted for a fix bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding support for multiple Azure Clouds microsoft/msticpy
1 participant
@ianhelle