Adding support for multiple Azure Clouds#193
Merged
Conversation
Now using Kqlmagic.kql() function in kql_driver. Allows it to be used from python code.
…as_function-2021-08-04 Merging fixes from mordor branch into here.
Adding cloud options to settings, kql_driver and keyvault Updated help text and combined CESimpleSettings class.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…thub.com/microsoft/msticpy into ianhelle/azure-cloud-settings-2021-08-06
Contributor
Author
|
@petebryan - I've reviewed your code but can't approve my own PR. |
…from config azure_auth.py - uses AzureCloudConfig, added credential_scopes option SubscriptionClient init, spelling corrections azure_auth_core.py - create AzureCloudConfig, and _AzCachedConnect classes to read cloud config values and cache tokens cred_wrapper.py - minor formatting keyvault_settings.py - usea AzureCloudConfig ce_common.py - uses AzureCloudConfig in get_def_tenant_id function azure_data.py - uses AzureCloudConfig, added credential_scopes option to client class inits, spelling corrections azure_sentinel.py - uses AzureCloudConfig. added functions to set default subscription and workspace, changed _build_paths to method kql_driver.py - uses AzureCloudConfig, added load_mode == Silent, added mp_az_auth to control using Azure auth instead of native Kqlmagic auth, resource_graph_driver.py - uses AzureCloudConfig, added credential_scopes option SubscriptionClient init pivot_magic_core.py - fixing pandas deprecation warning test_azure_auth_core - Added test for AzureCloudConfig class test_resource_graph_driver.py, test_azure_data.py, test_azure_sentinel.py - added real credential classes to test msticpyconfig-test.yaml, msticpyconfig.yaml - added Azure sections to test config.
…resource_graph_driver.py
This was
linked to
issues
Sep 2, 2021
Closed
petebryan
approved these changes
Sep 8, 2021
juju4
pushed a commit
to juju4/msticpy
that referenced
this pull request
Jun 5, 2022
* Kqlmagic operations called as func vs. IPython magics Now using Kqlmagic.kql() function in kql_driver. Allows it to be used from python code. * Fixing Mordor URL again. * Fixes to data paths and metadata in mordor driver * Fixing test paths due to AV isolating file. * Fixing bug where KQL env var was overwritten * removing explicit identifier from test in test_mordor_driver Adding cloud options to settings, kql_driver and keyvault Updated help text and combined CESimpleSettings class. * Updating Notice.txt file * Test failures from new changes * Azure auth multicloud support * Replacing hard-coded URIs with msrestazure enums * Modularize multicloud support * Linting fixes * Fix way endpoints are retreived * updated types * cred-scan suppression * Refactoring code to use AzureCloudConfig instead of reading directly from config azure_auth.py - uses AzureCloudConfig, added credential_scopes option SubscriptionClient init, spelling corrections azure_auth_core.py - create AzureCloudConfig, and _AzCachedConnect classes to read cloud config values and cache tokens cred_wrapper.py - minor formatting keyvault_settings.py - usea AzureCloudConfig ce_common.py - uses AzureCloudConfig in get_def_tenant_id function azure_data.py - uses AzureCloudConfig, added credential_scopes option to client class inits, spelling corrections azure_sentinel.py - uses AzureCloudConfig. added functions to set default subscription and workspace, changed _build_paths to method kql_driver.py - uses AzureCloudConfig, added load_mode == Silent, added mp_az_auth to control using Azure auth instead of native Kqlmagic auth, resource_graph_driver.py - uses AzureCloudConfig, added credential_scopes option SubscriptionClient init pivot_magic_core.py - fixing pandas deprecation warning test_azure_auth_core - Added test for AzureCloudConfig class test_resource_graph_driver.py, test_azure_data.py, test_azure_sentinel.py - added real credential classes to test msticpyconfig-test.yaml, msticpyconfig.yaml - added Azure sections to test config. * Fixing some issues in unit tests - test_provider_secrets.py and test_resource_graph_driver.py * Update azure-mgmt-subscription and azure_mgmt-resource versions * Adding a bit more text/warning to check the browser. Co-authored-by: Pete Bryan <pebryan@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Azure settings section containing cloud and auth_methods entries.
Updated settings editor to show these.
Updated KeyVault settings to use these global settings if nothing provided for Key Vault
Updated kql_driver settings to use Azure cloud settings for its cloud settings.