Timeline duration control #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tidying up some of the code in timeline.py Moving the pd accessors to timeline_pd_accessor.py Updating notebook EventTimeline.ipynb and documentation EventTimeline.rst
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
2xyo
reviewed
Jun 23, 2021
| ref_events: Optional[pd.DataFrame] = None | ||
| ref_col: Optional[str] = None | ||
| ref_times: Optional[List[Tuple[datetime, str]]] = None | ||
|
|
There was a problem hiding this comment.
range_tool and source_columns are missing :)
There was a problem hiding this comment.
Thx. source_columns is missing by design. Since the way I create the durations is by grouping on the group_by column(s) and then finding the max and min of the timestamps, all of the other field values for individual events disappear.
They kind of have to be ignored really since I'm trying to assign Tooltip values to the entire duration - so only values that are common to the grouped duration can be shown.
range_tool is an omission. I think I've fixed in an update with tests that I'm about to push.
Updating EventTimeline.ipynb with latest docstrings
Suppressing McCabe complexity error in _check_nb_check_ver in azure_ml_tools.py Updating version to 1.3.0
petebryan
approved these changes
Jun 29, 2021
…uration-2021-06-21
juju4
pushed a commit
to juju4/msticpy
that referenced
this pull request
Jun 5, 2022
* Timeline duration control Tidying up some of the code in timeline.py Moving the pd accessors to timeline_pd_accessor.py Updating notebook EventTimeline.ipynb and documentation EventTimeline.rst * Correcting docstrings and adding tests for legend = "none" Updating EventTimeline.ipynb with latest docstrings * Fix to remove casefold of OptionButtons value * Adding some safety checks to nb_check.py * McCabe suppression and version update Suppressing McCabe complexity error in _check_nb_check_ver in azure_ml_tools.py Updating version to 1.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new timeline control - displaying start-end durations of grouped events.
Tidying up some of the code in timeline.py
Moving the pd accessors to timeline_pd_accessor.py
Updating notebook EventTimeline.ipynb and documentation EventTimeline.rst