Fix for list_hunting_queries function #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for list_hunting_queries function, referred to alert_rules api, which does not contain such. Rather going towards savedSearches endpoint. It could also be pointed out somewhere that this is for custom queries only, i.e. Provider="Custom Queries"
petebryan
approved these changes
May 31, 2022
|
Thanks @pensivepaddle - this API is returning some of the built in hunting queries but not all of them. I will raise this with the product team and see if we can identify the reason for this discrepency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for list_hunting_queries function, referred to alert_rules api, which does not contain such.
Rather going towards savedSearches endpoint.
It could also be pointed out somewhere that this is for custom queries only, i.e. Provider="Custom Queries"