Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ianhelle/sentinel workspace lookup 2022 05 19 #419

Merged

Conversation

ianhelle
Copy link
Contributor

  • Sentinel workspaces mixin class added to MicrosoftSentinel - sentinel_workspaces.py and sentinel_core.py

  • Added workspace lookup functionality to MpConfigEdit and MpConfigFile - mp_config_file.py and ce_azure_sentinel.py

  • Added documentation in SentinelWorkspaces.rst and SettingsEditor.rst

  • Add Resource Graph queries for Sentinel in sentinel_resources.yaml

  • Moved AML-specific code from nbinit.py to azure_ml_tools.py - changed default search paths:

    • for msticpyconfig to start from "." instead of ".."
    • for config.json to start from aml user folder
  • Unit test in test_sentinel_workspaces.py

  • Moved azure and sentinel unit tests to tests\context\azure

  • Moved test_azure_blob_storage.py to tests\data\storage

  • Moved test_azuredata.py to tests\context\azure

  • Changed test_azuresent_connect_fail to use Mocks - otherwise tries live connect with a really long timeout

  • Added a couple of other unit tests to test_sentinel_core.py

  • Fixed logic in OPR test in test_tiproviders.py

  • Fixed test logic error in test_nbinit.py::test_check_config

  • Regenerated API docs causing a few unrelated changes.

ianhelle and others added 8 commits May 18, 2022 19:27
…r.py

Removed auto-load of VT Pivots - causes an exception when vt SDK is not installed - in nbinit.py
Added check for null config values in user_config.py
Added requirement for typing-extensions 4.2.0 (required by bokeh)
Moved conda-sourced packages to main conda requirements files.
…_workspaces.py and sentinel_core.py

Added workspace lookup functionality to MpConfigEdit and MpConfigFile - mp_config_file.py and ce_azure_sentinel.py
Added documentation in SentinelWorkspaces.rst and SettingsEditor.rst
Add Resource Graph queries for Sentinel in sentinel_resources.yaml
Moved AML-specific code from nbinit.py to azure_ml_tools.py - changed default search paths
- for msticpyconfig to start from "." instead of ".."
- for config.json to start from aml user folder
Unit test in test_sentinel_workspaces.py
Moved azure and sentinel unit tests to tests\context\azure
Moved test_azure_blob_storage.py to tests\data\storage
Moved test_azuredata.py to tests\context\azure
Changed test_azuresent_connect_fail to use Mocks - otherwise tries live connect with a *really* long timeout
Added a couple of other unit tests to test_sentinel_core.py
Fixed logic in OPR test in test_tiproviders.py
Fixed test logic error in test_nbinit.py::test_check_config
Regenerated API docs causing a few unrelated changes.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@petebryan petebryan merged commit 3f32e00 into release/msticpy-v2.0.0 May 31, 2022
@petebryan petebryan deleted the ianhelle/sentinel-workspace-lookup-2022-05-19 branch May 31, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve default behavior in WorkspaceConfig for config file source and workspace selection
2 participants