Inability to fetch "all" incidents, only 50 #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can tell, as of latest commit, d87b394 of sentinel_core.py, only 50 incidents are returned. The current implementation does not seem to respect the `nextLink` returned by the API and thus does not seem to paginate over incidents. Perhaps an issue in the msticpy repo would be better suited for this report.
ianhelle
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, as of latest commit, d87b394 of sentinel_core.py, only 50 incidents are returned.
The current implementation does not seem to respect the
nextLinkreturned by the API and thus does not seem to paginate over incidents.(I also realize that some sort of limitation and filtering functionality would be very handy if one indeed were about to fetch "all"...)