Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalDataDriver for using CSV and pickled DF files as a QueryProvider #64

Merged
merged 5 commits into from May 21, 2020

Conversation

ianhelle
Copy link
Contributor

Removed deprecated kql.py, query_builtin_queries, query_mgr.py, query_schema.py
Changed location of query_defns.py and made pkg reference updates in several modules and notebooks.
Some fixes to support local_data_driver in query_store.py, driver_base.py and data_providers.py
Unit test - test_localdata_queries.yaml and supporting data and query files.
Fixed test in test_utils.py to work on Linux
Add documentation for LocalDataDriver to DataProviders.rst and updated section on creating query files.
Reduced warnings produced during pytest run to something more reasonable.

Removed deprecated kql.py, query_builtin_queries, query_mgr.py, query_schema.py
Changed location of query_defns.py and made pkg reference updates in several modules and notebooks.
Some fixes to support local_data_driver in query_store.py, driver_base.py and data_providers.py
Unit test - test_localdata_queries.yaml and supporting data and query files.
Fixed test in test_utils.py to work on Linux
Add documentation for LocalDataDriver to DataProviders.rst and updated section on creating query files.
Reduced warnings produced during pytest run to something more reasonable.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

petebryan
petebryan previously approved these changes May 19, 2020
Copy link
Contributor

@petebryan petebryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

docs/source/data_acquisition/DataProviders.rst Outdated Show resolved Hide resolved
docs/source/data_acquisition/DataProviders.rst Outdated Show resolved Hide resolved
docs/source/data_acquisition/DataProviders.rst Outdated Show resolved Hide resolved
docs/source/data_acquisition/DataProviders.rst Outdated Show resolved Hide resolved
docs/source/msticpy.nbtools.rst Outdated Show resolved Hide resolved
msticpy/sectools/tiproviders/kql_base.py Show resolved Hide resolved
Changed tilookup and kql_base/kql_driver so that handling failure to load is a bit friendlier.
E.g. running TILookup in a non-IPython environment (with ASTI provider) will now just cause a warning, not an exception.
kql_driver.py also updated to check for get_ipython() returning None and output friendlier message.
Change driver_base.py and derived class to take additional QuerySource parameter for query() method - not yet used but
required so that we can implement driver-specific checks on query parameters.
Updated DataQueries.rst with new queries
Checked in notebook to create DataQueries.rst
Removed deprecated class from query_defns.py
Copy link
Contributor

@petebryan petebryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the QueryProviderDocumenter - great idea.



msticpy.nbtools.query\_defns module
msticpy.data.query\_defns module
-----------------------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

underline is too long now :)

@ianhelle ianhelle merged commit 3cd7293 into master May 21, 2020
@ianhelle ianhelle deleted the LocalDataProvider branch May 21, 2020 15:46
juju4 pushed a commit to juju4/msticpy that referenced this pull request Jun 5, 2022
…microsoft#64)

* LocalDataDriver for using CSV and pickled DF files as a QueryProvider

Removed deprecated kql.py, query_builtin_queries, query_mgr.py, query_schema.py
Changed location of query_defns.py and made pkg reference updates in several modules and notebooks.
Some fixes to support local_data_driver in query_store.py, driver_base.py and data_providers.py
Unit test - test_localdata_queries.yaml and supporting data and query files.
Fixed test in test_utils.py to work on Linux
Add documentation for LocalDataDriver to DataProviders.rst and updated section on creating query files.
Reduced warnings produced during pytest run to something more reasonable.

* Added "AzureSentinel" alias for LogAnalytics DataEnvironment

Changed tilookup and kql_base/kql_driver so that handling failure to load is a bit friendlier.
E.g. running TILookup in a non-IPython environment (with ASTI provider) will now just cause a warning, not an exception.
kql_driver.py also updated to check for get_ipython() returning None and output friendlier message.
Change driver_base.py and derived class to take additional QuerySource parameter for query() method - not yet used but
required so that we can implement driver-specific checks on query parameters.

* Fixing PR comments for docs (plus a few other things I saw)

Updated DataQueries.rst with new queries
Checked in notebook to create DataQueries.rst
Removed deprecated class from query_defns.py

* Typo in warning

* Missing parenthesis in DataProviders.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants