[202405][REBASE&FF]MdeModulePkg: VariableRuntimeDxe: Add host-based unit tests #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
impact:non-functional
Javagedes
changed the title
Javagedes
force-pushed
the
variable-sct-to-host-based-test
branch
from
e63bdf4
to
21c1c0a
Compare
Javagedes
force-pushed
the
variable-sct-to-host-based-test
branch
4 times, most recently
from
cad4a0b
to
38ab522
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202405 #967 +/- ##
=================================================
Coverage ? 0.60%
=================================================
Files ? 633
Lines ? 217575
Branches ? 1337
=================================================
Hits ? 1317
Misses ? 216213
Partials ? 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Javagedes
force-pushed
the
variable-sct-to-host-based-test
branch
from
38ab522
to
785b5bd
Compare
makubacki
reviewed
Jul 2, 2024
MdeModulePkg/Universal/Variable/RuntimeDxe/RuntimeDxeUnitTest/BlackBoxTest/Guid.c
Outdated
Show resolved
Hide resolved
makubacki
approved these changes
Jul 2, 2024
Javagedes
force-pushed
the
variable-sct-to-host-based-test
branch
4 times, most recently
from
70d3fc6
to
58d3cc3
Compare
os-d
approved these changes
Jul 12, 2024
Javagedes
force-pushed
the
variable-sct-to-host-based-test
branch
10 times, most recently
from
d128404
to
41dff02
Compare
This test will enable direct testing of the variable logic (including the logic common to all drivers) without having to load a full simulator or emulator. Configures emulated non-volatile variables in order to test the entire functionality. Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com>
added 2 commits
July 17, 2024 16:17
Copy SCT tests for VariableRuntimeDxe in preparation for using them as Host-based unit tests and updates their license format to follow edk2 standards. NOTE: Will not build yet. This import is kept separate from the changes to get things building so that it's easy to track the build changes. Co-authored-by: Joey Vagedes<joey.vagedes@gmail.com>
This requires a number of changes to the SCT test cases as well as some additional scaffolding to adapt the test cases to the host-based framework.
Javagedes
force-pushed
the
variable-sct-to-host-based-test
branch
from
41dff02
to
0f3a359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds hostbased unit tests for VariableRuntimeDxe including converting some Self Certification Test (SCT)s into Host Based Unit Tests.
Includes:
c060ede
d1ed38e
863063f
68670a0
090e049
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
<Please describe the test(s) that were run to verify the changes.>
Integration Instructions
<Describe how these changes should be integrated. Use N/A if nothing is required.>