v2023110001.0.1
What's Changed
-
CryptoPkg/RuntimeDxeCryptLib: Make globals static @makubacki (#741)
Change Details
## Description
The GNU linker (ld) raises an error due to duplicate symbols for the
mVirtualAddressChangeEvent
global. This change updates both globals
in the file to be static to prevent future symbol collisions.- Impacts functionality?
- Functionality - Does the change ultimately impact how firmware functions?
- Examples: Add a new library, publish a new PPI, update an algorithm, ...
- Impacts security?
- Security - Does the change have a direct security impact on an application,
flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter
validation improvement, ...
- Security - Does the change have a direct security impact on an application,
- Breaking change?
- Breaking change - Will anyone consuming this change experience a break
in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call
a function in a new library class in a pre-existing module, ...
- Breaking change - Will anyone consuming this change experience a break
- Includes tests?
- Tests - Does the change include any explicit test code?
- Examples: Unit tests, integration tests, robot tests, ...
- Includes documentation?
- Documentation - Does the change contain explicit documentation additions
outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation
on an a separate Web page, ...
- Documentation - Does the change contain explicit documentation additions
How This Was Tested
- Built
VariableRuntimeDxe
using GCC on Ubuntu with theRuntimeDxeCryptLib
library instance linked.
Integration Instructions
N/A
- Impacts functionality?
-
BaseTools/GenFds: Resolve absolute workspace INF paths @makubacki (#740)
Change Details
## Description
Currently, if an INF path is an absolute path on Linux (begins with
"/"), the "/" character will be removed. If the path is an absolute
system path, this creates an invalid path.This creates an issue, for example, if an INF is in an ext dep where
the ext dep has theset_build_var
flag set and DSC files refer to
files by its build variable (e.g.$(SHARED_CRYPTO_PATH)/Module.inf
).$(SHARED_CRYPTO_PATH)
will be an absolute path to the ext dep
directory andFfsInfStatement.__InfParse__
will remove the leading
"/" character so the path is invalid.This change first checks if the absolute path will resolve into the
current workspace. If it does (as will happen in the shared crypto
ext dep example above), it modifies the path to be relative to the
workspace so later logic dependent on relative paths can operate on
it. If the absolute path is not within the current workspace, it
follows previous behavior for backward compatibility to that
scenario.- Impacts functionality?
- Functionality - Does the change ultimately impact how firmware functions?
- Examples: Add a new library, publish a new PPI, update an algorithm, ...
- Impacts security?
- Security - Does the change have a direct security impact on an application,
flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter
validation improvement, ...
- Security - Does the change have a direct security impact on an application,
- Breaking change?
- Breaking change - Will anyone consuming this change experience a break
in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call
a function in a new library class in a pre-existing module, ...
- Breaking change - Will anyone consuming this change experience a break
- Includes tests?
- Tests - Does the change include any explicit test code?
- Examples: Unit tests, integration tests, robot tests, ...
- Includes documentation?
- Documentation - Does the change contain explicit documentation additions
outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation
on an a separate Web page, ...
- Documentation - Does the change contain explicit documentation additions
How This Was Tested
- Build with the change against Mu Basecore CI and Mu Tiano Platforms platform builds.
- Build on Ubuntu with an ext dep that sets an absolute path in a build variable that
is used to build an INF file. Verify failure before and success after the change.
Integration Instructions
N/A
- Impacts functionality?
Full Changelog: v2023110001.0.0...v2023110001.0.1