Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinPlatformPkg SerialPortTerminalLib: Fixing CodeQL issue Pointless comparison of unsigned value to zero. #282

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

apop5
Copy link
Contributor

@apop5 apop5 commented Aug 7, 2024

Description

CodeQL is reporting Pointless comparison of unsigned value to zero for a value derived from an unsigned PCD PcdDefaultTerminalType.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Ran Local CI.

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Aug 7, 2024
@apop5 apop5 requested review from kenlautner and os-d August 7, 2024 23:08
Copy link

@os-d os-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like 99% of this is uncrustify. Do we run uncrustify here? If so, should that be a separate commit?

@apop5
Copy link
Contributor Author

apop5 commented Aug 7, 2024

Looks like 99% of this is uncrustify. Do we run uncrustify here? If so, should that be a separate commit?

Good Point. I reverted the uncrustify changes.

@apop5 apop5 enabled auto-merge (squash) August 7, 2024 23:43
@apop5 apop5 merged commit 03664aa into microsoft:release/202311 Aug 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants