Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Building for AARCH64 for OemPkg does not link stack cookies #118

Closed
1 task done
Flickdm opened this issue Jul 13, 2023 · 0 comments
Closed
1 task done

[Bug]: Building for AARCH64 for OemPkg does not link stack cookies #118

Flickdm opened this issue Jul 13, 2023 · 0 comments
Assignees
@Flickdm
Labels
state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working urgency:low Little to no impact

Comments

@Flickdm
Copy link
Member

Flickdm commented Jul 13, 2023

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

If you attempt to build OemPkg using stuart_ci_build with GCC on WSL2 for AARCH64 you will see the be met with linker errors

Expected Behavior

OemPkg should be built correctly

Steps To Reproduce

  1. Create a WSL2 Environment to build Project MU
  2. Clone this repo
  3. stuart_ci_setup -c .pytool/CISettings.py TOOL_CHAIN_TAG=GCC5
  4. stuart_update -c .pytool/CISettings.py TOOL_CHAIN_TAG=GCC5
  5. stuart_ci_build -c .pytool/CISettings.py TOOL_CHAIN_TAG=GCC5

Build Environment

- OS(s):
   - WSL2 Ubuntu 22.04.2
- Tool Chain(s):
   - GCC5
- Targets Impacted:
   - AARCH64

Version Information

release/202302 and below

Urgency

Low

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response
@Flickdm Flickdm added type:bug Something isn't working state:needs-triage Needs to triaged to determine next steps labels Jul 13, 2023
@github-actions github-actions bot added urgency:low Little to no impact labels Jul 13, 2023
@Flickdm Flickdm mentioned this issue Jul 13, 2023
Merged
5 tasks
Flickdm added a commit that referenced this issue Jul 13, 2023
@Flickdm
adding stack cookie support (#119)
bcd2bdc 
# Preface

Please ensure you have read the [contribution
docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior
to submitting the pull request. In particular,
[pull request
guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices).

## Description

[Issue 118](#118)

For each item, place an "x" in between `[` and `]` if true. Example:
`[x]`.
_(you can also check items in the GitHub UI)_

- [X] Impacts functionality?
- Yes, builds with stack cookies by default for OemPkg when using
`stuart_ci_build`
- [X] Impacts security?
  - Yes, adds stack cookies
- [ ] Breaking change?
  - This shouldn't be breaking
- [ ] Includes tests?
  - No
- [ ] Includes documentation?
  - No

## How This Was Tested

This was built in a windows environment with VS2022 using
stuart_ci_build and built on a linux environment using WSL2 on ubuntu
22.04.2 using GCC5

## Integration Instructions

N/A
@Flickdm Flickdm closed this as completed Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Flickdm Flickdm

Labels
state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working urgency:low Little to no impact
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Flickdm