Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Uncrustify break #112

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Fixing Uncrustify break #112

merged 1 commit into from
Jun 26, 2023

Conversation

kuqin12
Copy link
Contributor

@kuqin12 kuqin12 commented Jun 26, 2023

Preface

Please ensure you have read the contribution docs prior
to submitting the pull request. In particular,
pull request guidelines.

Description

This change fixed an Uncrustify failure on the latest top of mainline branch.

For each item, place an "x" in between [ and ] if true. Example: [x].
(you can also check items in the GitHub UI)

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Uncrustify fix, no functional change.

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Jun 26, 2023
@kuqin12
Copy link
Contributor Author

kuqin12 commented Jun 26, 2023

Not sure how it got away from the original PR gate.

@kuqin12 kuqin12 merged commit 2ca270b into microsoft:release/202302 Jun 26, 2023
15 checks passed
@kuqin12 kuqin12 deleted the fix_uncrustify branch June 26, 2023 21:42
@ProjectMuBot ProjectMuBot mentioned this pull request Jun 29, 2023
Merged
ProjectMuBot added a commit to microsoft/mu_tiano_platforms that referenced this pull request Jun 29, 2023
@ProjectMuBot
Bumps Common/MU_OEM_SAMPLE from 2023020000.0.2 to 2023020000.0.3
ee41fd0 
Introduces 3 new commits in [Common/MU_OEM_SAMPLE](https://github.com/microsoft/mu_oem_sample.git).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/1ddac5100a75a59f7c06b701d9a9bc223eaa7c64">1ddac5</a> Display the Type 1 serial number instead of the Type 3 serial number (<a href="https://github.com/microsoft/mu_oem_sample/pull/104">#104</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/2ca270b989185eba7782a24bd19c1fcb9a7b5cd2">2ca270</a> Fixing Uncrustify break (<a href="https://github.com/microsoft/mu_oem_sample/pull/112">#112</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/6474d1adaaffa9ec81141b0cab56f53a7a437362">6474d1</a> ci.yaml: add PrEval entry</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <mubot@microsoft.com>
makubacki pushed a commit to microsoft/mu_tiano_platforms that referenced this pull request Jun 29, 2023
@ProjectMuBot
Bump Common/MU_OEM_SAMPLE from 2023020000.0.2 to 2023020000.0.3 (#618)
ab65fe7 
Bumps Common/MU_OEM_SAMPLE from `2023020000.0.2` to `2023020000.0.3`

Introduces 3 new commits in
[Common/MU_OEM_SAMPLE](https://github.com/microsoft/mu_oem_sample.git).

<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/microsoft/mu_oem_sample/commit/1ddac5100a75a59f7c06b701d9a9bc223eaa7c64">1ddac5</a>
Display the Type 1 serial number instead of the Type 3 serial number (<a
href="https://github.com/microsoft/mu_oem_sample/pull/104">#104</a>)</li>
<li><a
href="https://github.com/microsoft/mu_oem_sample/commit/2ca270b989185eba7782a24bd19c1fcb9a7b5cd2">2ca270</a>
Fixing Uncrustify break (<a
href="https://github.com/microsoft/mu_oem_sample/pull/112">#112</a>)</li>
<li><a
href="https://github.com/microsoft/mu_oem_sample/commit/6474d1adaaffa9ec81141b0cab56f53a7a437362">6474d1</a>
ci.yaml: add PrEval entry</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <mubot@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makubacki makubacki makubacki approved these changes

@TaylorBeebe TaylorBeebe TaylorBeebe approved these changes

@kenlautner kenlautner Awaiting requested review from kenlautner

Assignees
No one assigned
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kuqin12 @makubacki @TaylorBeebe