Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple UEFI application - HelloUefi #116

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Add simple UEFI application - HelloUefi #116

merged 1 commit into from
Jul 6, 2023

Conversation

Flickdm
Copy link
Member

@Flickdm Flickdm commented Jul 6, 2023 •
edited

Description

This is the simplest possible UEFI application. It differs from 'HelloWorld' by dropping PCD logic and dependencies

  • Impacts functionality?

  • Impacts security?

  • Breaking change?

  • Includes tests?

  • Includes documentation?

How This Was Tested

Ran on QemuQ35

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Jul 6, 2023
@Flickdm Flickdm requested review from os-d and apop5 July 6, 2023 20:54
@Flickdm Flickdm enabled auto-merge (squash) July 6, 2023 20:54
os-d
os-d approved these changes Jul 6, 2023
View reviewed changes
OemPkg/OemPkg.dsc Show resolved Hide resolved
OemPkg/HelloUefi/HelloUefi.inf Show resolved Hide resolved
makubacki
makubacki reviewed Jul 6, 2023
View reviewed changes
OemPkg/HelloUefi/HelloUefi.inf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comment that this is the simplest UEFI application possible in the file comments is sufficient, but in the PR Description it would be nice to add more detailed context about why this was created given https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Application/HelloWorld/HelloWorld.inf exists.

Eliminating PCD logic, dropping library dependencies, etc...

@Flickdm Flickdm merged commit 563c877 into microsoft:release/202302 Jul 6, 2023
11 of 15 checks passed
@makubacki makubacki changed the title HelloUefi init Add simple UEFI application - HelloUefi Jul 6, 2023
@makubacki
Copy link
Member

@Flickdm, it looks like this may have been accidentally merged?

@kuqin12
Copy link
Contributor

kuqin12 commented Jul 7, 2023

@Flickdm, it looks like this may have been accidentally merged?

Btw, this change is breaking the uncrustify check. Not sure how it got through the PR gate in the first place.

@makubacki
Copy link
Member

makubacki commented Jul 7, 2023 •
edited

@Flickdm, it looks like this may have been accidentally merged?

Btw, this change is breaking the uncrustify check. Not sure how it got through the PR gate in the first place.

The branch protection rules are inconsistent across branches in this repo. release/* did not require comment resolution, release/202208 did. I updated it, but @Flickdm, can you please address the uncrustify issues in a new PR? There's also some outstanding requests in this PR as well.

@makubacki makubacki mentioned this pull request Jul 7, 2023
Merged
5 tasks
@ProjectMuBot ProjectMuBot mentioned this pull request Jul 15, 2023
Merged
ProjectMuBot added a commit to microsoft/mu_tiano_platforms that referenced this pull request Jul 15, 2023
@ProjectMuBot
Bumps Common/MU_OEM_SAMPLE from 2023020000.0.3 to 2023020000.0.4
8cb9827 
Introduces 7 new commits in [Common/MU_OEM_SAMPLE](https://github.com/microsoft/mu_oem_sample.git).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/747440cedf1eef6180c00cb83d66736ef3aa45d6">747440</a> pip: update edk2-pytool-extensions requirement from ~=0.23.6 to ~=0.23.8 (<a href="https://github.com/microsoft/mu_oem_sample/pull/114">#114</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/b27b72aba283ab8a9a64846530775f535a36e31a">b27b72</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_oem_sample/pull/115">#115</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/563c877f0750b52f5b05327fae6f48fe60b28083">563c87</a> HelloUefi init (<a href="https://github.com/microsoft/mu_oem_sample/pull/116">#116</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/54d70cdf064947df64890672c2da73413c46fbe3">54d70c</a> OemPkg/HelloUefi - CI fixes (<a href="https://github.com/microsoft/mu_oem_sample/pull/117">#117</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/bcd2bdcb4c2f66c29b1e0025b739b0383ee346c6">bcd2bd</a> adding stack cookie support (<a href="https://github.com/microsoft/mu_oem_sample/pull/119">#119</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/d479c883e15187f09138bc51bd604f7af250e0d8">d479c8</a> HelloUefi: Add 30 second stall (<a href="https://github.com/microsoft/mu_oem_sample/pull/120">#120</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/746b4426487c9f254657e0d1ee461e5e819ee81b">746b44</a> OemPkg: Fix build (<a href="https://github.com/microsoft/mu_oem_sample/pull/121">#121</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <mubot@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makubacki makubacki makubacki approved these changes

@os-d os-d os-d approved these changes

@apop5 apop5 Awaiting requested review from apop5

Assignees
No one assigned
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Flickdm @makubacki @kuqin12 @os-d