Add Rust Support and Advanced Logger Crate [Rebase & FF] #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makubacki
added
type:enhancement
joschock
approved these changes
Aug 22, 2023
makubacki
force-pushed
the
add_rust_build_support
branch
from
d18b62b
to
4d4f644
Compare
makubacki
commented
Aug 24, 2023
Javagedes
reviewed
Aug 24, 2023
Javagedes
approved these changes
Aug 24, 2023
makubacki
force-pushed
the
add_rust_build_support
branch
from
4d4f644
to
dc194de
Compare
Adds workspace level files to build Rust in the repo. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Makes the changes needed to build Rust in pipelines on Windows and Linux. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
add_rust_build_support
branch
from
dc194de
to
5f7926b
Compare
apop5
reviewed
Aug 24, 2023
apop5
approved these changes
Aug 24, 2023
Adds a library crate that serves as a Rust wrapper for access to the Advanced Logger protocol. Co-authored-by: John Schock <joschock@microsoft.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
add_rust_build_support
branch
from
5f7926b
to
3c8b4ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #294
Description
Updates the repo to add some files needed to support Rust builds and a
RustAdvancedLoggerDxelibrary crate.Because this repo was used to test the Rust build and is adding a new crate in that process, the infrastructure files are added directly in this PR. In the future, these will be synced from
mu_devops. The file content aligns with the current templates inmu_devopsso there should be no change in the sync process in this repo. Future repos can simply sync the files with the bot accounts and then add the Rust code in a follow up PR.The ability to build with Rust is temporarily disabled in the last commit of the PR branch because changes in
mu_devopsneed to be completed before the pipeline build in this repo will succeed.Commit/Change Overview
Add initial Rust infrastructure files
Adds workspace level files to build Rust in the repo.
.azurepipelines: Add Rust build support
Makes the changes needed to build Rust in pipelines on Windows
and Linux.
AdvLoggerPkg: Add RustAdvancedLoggerDxe
Adds a library crate that serves as a Rust wrapper for access to
Advanced Logger protocol.
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
Integration Instructions
No changes are needed for mu_plus integrators.
Review general Rust documentation in mu_basecore for more info.