Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax report length requirements #455

Merged

Conversation

joschock
Copy link
Contributor

@joschock joschock commented Mar 30, 2024

Description

This PR brings in two fixes to support a wider variety of devices, some of which might not be completely self-consistent:

  • Allow report lengths that don't match the report descriptor. Reports that are shorter than the Report Descriptor specifies will be processed for whatever fields are fully present. Reports that are longer than the Report descriptor specifies will simply ignore the extra bytes in the report.
  • Move away from using signal_event to force keyboard layout initialization, and install call the layout change routine directly. This avoids introducing sequencing issues based on the TPL that the keyboard is being initialized at, resulting in more deterministic behavior.
  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Rust unit tests updated to cover new functionality all pass. Functional testing on hardware with the changes also passes.

Integration Instructions

N/A

@github-actions github-actions bot added the impact:testing Affects testing label Mar 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.01%. Comparing base (b748acb) to head (d35ebcb).

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/202311     #455      +/-   ##
==================================================
- Coverage           12.11%   12.01%   -0.11%     
==================================================
  Files                 110      110              
  Lines               19024    19003      -21     
  Branches             1735     1735              
==================================================
- Hits                 2305     2283      -22     
+ Misses              16687    16674      -13     
- Partials               32       46      +14     
Flag Coverage Δ
HidPkg 2.12% <ø> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Flickdm Flickdm enabled auto-merge (squash) April 18, 2024 20:28
@Flickdm Flickdm merged commit cd7ce3e into microsoft:release/202311 Apr 18, 2024
29 checks passed
ProjectMuBot added a commit to microsoft/mu_tiano_platforms that referenced this pull request Apr 27, 2024
Introduces 3 new commits in [Common/MU](https://github.com/microsoft/mu_plus.git).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_plus/commit/cd7ce3ed8ae3ab38cdff67df6b8379a343347d52">cd7ce3</a> Relax report length requirements (<a href="https://github.com/microsoft/mu_plus/pull/455">#455</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/e6308e0591505cacf9a142d4f091fd863f9f2fc8">e6308e</a> GitHub Action: Bump robinraju/release-downloader from 1.9 to 1.10 (<a href="https://github.com/microsoft/mu_plus/pull/472">#472</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/da051c707f056617f8e10bf9f3cc5071bc504d83">da051c</a> Moving the global variable from header file into library instances (<a href="https://github.com/microsoft/mu_plus/pull/473">#473</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <mubot@microsoft.com>
apop5 pushed a commit to microsoft/mu_tiano_platforms that referenced this pull request Apr 29, 2024
Bumps Common/MU from `2023110000.0.5` to `2023110000.0.6`


Introduces 3 new commits in
[Common/MU](https://github.com/microsoft/mu_plus.git).

<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/microsoft/mu_plus/commit/cd7ce3ed8ae3ab38cdff67df6b8379a343347d52">cd7ce3</a>
Relax report length requirements (<a
href="https://github.com/microsoft/mu_plus/pull/455">#455</a>)</li>
<li><a
href="https://github.com/microsoft/mu_plus/commit/e6308e0591505cacf9a142d4f091fd863f9f2fc8">e6308e</a>
GitHub Action: Bump robinraju/release-downloader from 1.9 to 1.10 (<a
href="https://github.com/microsoft/mu_plus/pull/472">#472</a>)</li>
<li><a
href="https://github.com/microsoft/mu_plus/commit/da051c707f056617f8e10bf9f3cc5071bc504d83">da051c</a>
Moving the global variable from header file into library instances (<a
href="https://github.com/microsoft/mu_plus/pull/473">#473</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <mubot@microsoft.com>

---------

Signed-off-by: Project Mu Bot <mubot@microsoft.com>
Co-authored-by: Kun Qin <kuqin@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:testing Affects testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants