Update reset notification list to be notified before NVMe #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is/was there a change to the NVMe code? If so, could you link that in the description for reference? |
|
There was no change to the NVMe code. The Reset System driver processes 3 queues. Both NVMe and AdvLogger were using the second queue processed by ResetSystemRuntimeDxe. AdvLogger was changed to use the first queue processed by ResetSystemRuntimeDxe. |
|
Not sure about this change. You are leveraging the "filter" list. |
spbrogan
requested changes
Oct 25, 2022
apop5
approved these changes
Nov 29, 2022
spbrogan
approved these changes
Nov 29, 2022
github-actions bot
pushed a commit
to Erich-McMillan/mu_plus
that referenced
this pull request
Dec 9, 2022
## Description Reset notification was handled by the NVMe driver before the AdvLogger could write the log to disk. - [No] Breaking change? - Will this change break pre-existing builds or functionality without action being taken? ## How This Was Tested Tested on multiple systems. ## Integration Instructions N/A
github-actions bot
pushed a commit
to Erich-McMillan/mu_plus
that referenced
this pull request
Dec 9, 2022
## Description Reset notification was handled by the NVMe driver before the AdvLogger could write the log to disk. - [No] Breaking change? - Will this change break pre-existing builds or functionality without action being taken? ## How This Was Tested Tested on multiple systems. ## Integration Instructions N/A
github-actions bot
pushed a commit
to TaylorBeebe/mu_plus
that referenced
this pull request
Dec 9, 2022
## Description Reset notification was handled by the NVMe driver before the AdvLogger could write the log to disk. - [No] Breaking change? - Will this change break pre-existing builds or functionality without action being taken? ## How This Was Tested Tested on multiple systems. ## Integration Instructions N/A
kenlautner
pushed a commit
that referenced
this pull request
May 14, 2023
## Description Reset notification was handled by the NVMe driver before the AdvLogger could write the log to disk. - [No] Breaking change? - Will this change break pre-existing builds or functionality without action being taken? ## How This Was Tested Tested on multiple systems. ## Integration Instructions N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reset notification was handled by the NVMe driver before the AdvLogger could write the log to disk.
How This Was Tested
Tested on multiple systems.
Integration Instructions
N/A