Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Standalone MM Shared Crypto [Rebase & FF] #822

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

makubacki
Copy link
Member

Description

Updates Mu Basecore to include the Standalone MM shared crypto binaries
via the external dependency in CryptoPkg. Updates QemuQ35Pkg to use the
Standalone MM crypto binary.

QemuSbsaPkg is not modified as a Standalone MM binary is currently not
published for AARCH64.

  1. Bump MU_BASECORE from 2023020010.0.0 to 2023020011.0.0

    Introduces 9 new commits in
    MU_BASECORE.

    In particular, this release updates the shared crypto binary external
    dependency in CryptoPkg to include the Standalone MM binaries.

  2. QemuQ35Pkg: Use the Standalone MM shared crypto driver

    Updates Standalone MM modules to use the BaseCryptLibOnProtocolPpi/StandaloneMmCryptLib.inf
    instance of BaseCryptLib. This will allow those modules to use the gEdkiiSmmCryptoProtocolGuid
    protocol instance published by the Standalone MM crypto binary.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

  • QemuQ35Pkg local build and boot to EFI shell and Windows OS

Integration Instructions

N/A - Only impacts the QEMU Q35 platform.

Introduces 9 new commits in
[MU_BASECORE](https://github.com/microsoft/mu_basecore.git).

In particular, this release updates the shared crypto binary external
dependency in CryptoPkg to include the Standalone MM binaries.

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
@makubacki makubacki added platform:Q35 Specific to the Q35 platform type:design-change A new proposal or modification to a feature design labels Jan 18, 2024
@makubacki makubacki self-assigned this Jan 18, 2024
@github-actions github-actions bot added the impact:security Has a security impact label Jan 18, 2024
Cargo.lock Show resolved Hide resolved
Platforms/QemuQ35Pkg/QemuQ35Pkg.dsc Outdated Show resolved Hide resolved
Updates Standalone MM modules to use the `BaseCryptLibOnProtocolPpi/StandaloneMmCryptLib.inf`
instance of `BaseCryptLib`. This will allow those modules to use the `gEdkiiSmmCryptoProtocolGuid`
protocol instance published by the Standalone MM crypto binary.

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
@makubacki makubacki force-pushed the use_standalonemm_shared_crypto branch from cdbfd16 to 11ab828 Compare January 18, 2024 17:37
@makubacki makubacki enabled auto-merge (rebase) January 18, 2024 17:39
@makubacki makubacki merged commit 4d3c861 into microsoft:main Jan 18, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:security Has a security impact platform:Q35 Specific to the Q35 platform type:design-change A new proposal or modification to a feature design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants