Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NETWORK_ENABLE option #940

Merged
merged 1 commit into from
May 9, 2024

Conversation

makubacki
Copy link
Member

Description

Simplifies network enabling by using a dedicated flag for enabling.

Preserves existing behavior where networking is disabled by default.

Networking was hardcoded to off in the QemuSbsaPkg runner, that is
not modified in this change.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

  • Run without flag set and verify networking is disabled.
  • Run with flag and verify networking is enabled.

Integration Instructions

N/A

Simplifies network enabling by using a dedicated flag for enabling.

Networking was hardcoded to off in the QemuSbsaPkg runner, that is
not modified in this change.

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
@makubacki makubacki added platform:Q35 Specific to the Q35 platform semver:patch Pull requests that should increment the release patch version labels May 9, 2024
@makubacki makubacki requested review from kuqin12 and apop5 May 9, 2024 20:52
@makubacki makubacki self-assigned this May 9, 2024
@github-actions github-actions bot added language:python Pull requests that update Python code impact:non-functional Does not have a functional impact labels May 9, 2024
@makubacki makubacki enabled auto-merge (squash) May 9, 2024 22:07
@makubacki makubacki merged commit a5262a3 into microsoft:main May 9, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact language:python Pull requests that update Python code platform:Q35 Specific to the Q35 platform semver:patch Pull requests that should increment the release patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants