FmpDevicePkg: Assert on PcdFmpDeviceImageTypeIdGuid Size Mismatch

This patch adds an assert to FmpDxe.c to catch a platform misconfiguration of PcdFmpDeviceImageTypeIdGuid.
microsoft · Jul 3, 2024 · a1eef99 · a1eef99
1 parent 62fc5b8
commit a1eef99
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c
@@ -181,7 +181,10 @@ GetImageTypeIdGuid (
     if (ImageTypeIdGuidSize == sizeof (EFI_GUID)) {
       FmpDeviceLibGuid = (EFI_GUID *)PcdGetPtr (PcdFmpDeviceImageTypeIdGuid);
     } else {
-      DEBUG ((DEBUG_WARN, "FmpDxe(%s): Fall back to ImageTypeIdGuid of gEfiCallerIdGuid\n", mImageIdName));
+      // MU_CHANGE start - this is a misconfiguration error, we should assert
+      ASSERT (FALSE);
+      DEBUG ((DEBUG_ERROR, "FmpDxe(%s): Fall back to ImageTypeIdGuid of gEfiCallerIdGuid. FmpDxe error: misconfiguration\n", mImageIdName));
+      // MU_CHANGE end
       FmpDeviceLibGuid = &gEfiCallerIdGuid;
     }
   }