-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SecurityPkg: Remove Support for _DSM Memory Clear #296
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202405 #296 +/- ##
=================================================
Coverage ? 91.05%
=================================================
Files ? 11
Lines ? 1778
Branches ? 200
=================================================
Hits ? 1619
Misses ? 143
Partials ? 16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have this split into two changes? The tcg2smm one seems to be removing a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change functionally seems fine, but touches 2 modules at the same time. I guess it will not be checked into edk2 as is.
I will split this into two commits. |
This patch removes the _DSM Memory Clear and MOR auto-detect functionality which is unused.
Remove unused MemoryClear SMI Handler, which is no longer used due to _DSM Memory Clear no longer being used.
Description
_DSM Memory Clear is not used, so this code removes it.
Cherry-picked from f911628.
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
From 2311.
Integration Instructions
N/A.