Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizers for coord check #16

Closed
xwjabc opened this issue Jun 1, 2022 · 2 comments
Closed

Optimizers for coord check #16

xwjabc opened this issue Jun 1, 2022 · 2 comments

Comments

@xwjabc
Copy link

xwjabc commented Jun 1, 2022

Thank you for your great work! When trying the coord check in the examples, I noticed that the original optimizers (e.g., sgd, adam) are used instead of the muP optimizers (e.g., musgd, muadam). However, according to the Table 8 in the paper, the optimizers should be adjusted accordingly to make activations bounded. Is there any reason behind the use of original optimizers?

@edwardjhu
Copy link
Collaborator

Hi Weijian,

The mup coordinate check curves do use mu-optimizers. The conversion happens internally:

if mup:

Does this address your concern?

@xwjabc
Copy link
Author

xwjabc commented Jun 1, 2022

Thank you for your quick reply! Yes, it addresses my concern. I just found out the auto conversion right before seeing your reply 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants