Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Notebook test for Gensen Local. #179

Merged
merged 4 commits into from
Jul 26, 2019
Merged

Notebook test for Gensen Local. #179

merged 4 commits into from
Jul 26, 2019

Commits on Jul 25, 2019

  1. Added integration test to Gensen Local notebook

    @AbhiramE
    AbhiramE committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    9b239f5 View commit details
    Browse the repository at this point in the history

  2. Fixed some messed conflict resolution

    @AbhiramE
    AbhiramE committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    ddf810f View commit details
    Browse the repository at this point in the history

  3. Changes for code review comments. 

    1. Added compute_correlation_coeff method to utils and separated it from
the predict method to ensure single responsbility.
2. Added tests accordingly.
3. In the notebook added a scrap to track preditions and assert it in
tests.
4. Also added extra documentation to explain what the predict method is
doing.
5. Minor fix to stop train at max_epoch.
    @AbhiramE
    AbhiramE committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    c6ab656 View commit details
    Browse the repository at this point in the history

  4. Minor fix to tests

    @AbhiramE
    AbhiramE committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    cd357d2 View commit details
    Browse the repository at this point in the history