This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 916
Hlu/update entailment notebook running time #237
Merged
miguelgfierro
merged 6 commits into
staging
from
hlu/update_entailment_notebook_running_time
Aug 7, 2019
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9f463ba
Add QUICK_RUN flag.
hlums c5e65c4
Add running time on single GPU machine.
hlums e1bb26f
Add integration test for entailment notebook.
hlums c8ac917
Update notebook parameters.
238e8d0
Resolved conflict with staging.
hlums f276d3c
Add pytest.mark.gpu
hlums File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
tests/integration/test_notebooks_entailment_multinli_bert.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
# Copyright (c) Microsoft Corporation. All rights reserved. | ||
# Licensed under the MIT License. | ||
|
||
import pytest | ||
import papermill as pm | ||
from tests.notebooks_common import OUTPUT_NOTEBOOK, KERNEL_NAME | ||
|
||
|
||
@pytest.mark.integration | ||
def test_entailment_multinli_bert(notebooks): | ||
notebook_path = notebooks["entailment_multinli_bert"] | ||
pm.execute_notebook( | ||
notebook_path, | ||
OUTPUT_NOTEBOOK, | ||
parameters={"TRAIN_DATA_USED_PERCENT": 0.001, | ||
"DEV_DATA_USED_PERCENT": 0.01, | ||
"NUM_EPOCHS": 1}, | ||
kernel_name=KERNEL_NAME, | ||
) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add
@pytest.mark.gpu
so this is executed with the gpu tests. Is there a reason why we also wanted to check this notebook on cpu?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. One of the reasons is that I'm still getting familiar with the pytest marks. :)
Previously, we did have a problem that the notebook works on GPU but not on CPU, but It's now fixed and the test is covered by the unit tests.