Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Hlu/add reference running time to more notebooks #267

Merged
merged 10 commits into from Aug 13, 2019

Conversation

hlums
Copy link
Collaborator

@hlums hlums commented Aug 12, 2019

Description

Add reference running time and integration tests to NER and text classification notebooks.

Related Issues

#213

Checklist:

  • My code follows the code style of this project, as detailed in our contribution guidelines.
  • I have added tests.
  • I have updated the documentation accordingly.

@review-notebook-app
Copy link

Check out this pull request on ReviewNB: https://app.reviewnb.com/microsoft/nlp/pull/267

You'll be able to see notebook diffs and discuss changes. Powered by ReviewNB.

@hlums hlums changed the base branch from master to staging August 12, 2019 18:30
@hlums hlums requested a review from saidbleik August 12, 2019 18:34
@@ -11,9 +11,64 @@
"# Text Classification of MultiNLI Sentences using BERT"
]
},
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's convenient. Thanks for adding those.
Can you merge the first cell with the params cell in the Introduction section and move the new 'second' cell after that?

@saidbleik saidbleik merged commit d7bc4e8 into staging Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants