Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiphase refactor and support OpenPAI training service. #1138

Merged
merged 24 commits into from
Jun 24, 2019
Merged

Multiphase refactor and support OpenPAI training service. #1138

merged 24 commits into from
Jun 24, 2019

Conversation

chicm-ms
Copy link
Contributor

@chicm-ms chicm-ms commented May 31, 2019 •
edited
Loading

  1. Refactoring multiphase interface, enable all builtin tuners as multiphase tuner, such as:
    image

  2. Support multiphase for OpenPAI training service.

@scarlett2018 scarlett2018 mentioned this pull request Jun 5, 2019
Closed
20 tasks
@scarlett2018 scarlett2018 added this to the June 2019 Release milestone Jun 5, 2019
@leckie-chn
Copy link
Contributor

another related issue: #1170

@chicm-ms chicm-ms requested review from SparkSnail, leckie-chn and yds05 and removed request for leckie-chn June 21, 2019 07:20
@chicm-ms chicm-ms changed the title Multiphase refactor Multiphase refactor and support OpenPAI training service. Jun 21, 2019
@QuanluZhang
Copy link
Contributor

looks good. We also have tuners under nni/examples/tuners, better to update the input argument in them as well :)

@chicm-ms
Copy link
Contributor Author

looks good. We also have tuners under nni/examples/tuners, better to update the input argument in them as well :)

Thanks, updated.

@QuanluZhang
Copy link
Contributor

@xuehui1991 there is an enas tuner referenced by our repo, could you update the tuner interface in it?

@QuanluZhang
Copy link
Contributor

@Crysple please update the tuner interface of the nas example in your repo after this pr is merged.

@QuanluZhang
Copy link
Contributor

@chicm-ms could you also update the doc/tutorial, for example: https://nni.readthedocs.io/en/latest/CustomizeTuner.html

@QuanluZhang
Copy link
Contributor

NNI Advisors (hyperband, BOHB) have not supported multi-phase, let me fix it after this pr is merged.

@chicm-ms
Copy link
Contributor Author

@chicm-ms could you also update the doc/tutorial, for example: https://nni.readthedocs.io/en/latest/CustomizeTuner.html

Done

@chicm-ms chicm-ms merged commit ac6aee8 into microsoft:master Jun 24, 2019
@scarlett2018 scarlett2018 mentioned this pull request Jun 26, 2019
Closed
23 tasks
@chicm-ms chicm-ms deleted the multiphase_refactor branch March 25, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuanluZhang QuanluZhang QuanluZhang approved these changes

@SparkSnail SparkSnail SparkSnail approved these changes

@xuehui1991 xuehui1991 Awaiting requested review from xuehui1991

@leckie-chn leckie-chn Awaiting requested review from leckie-chn

@yds05 yds05 Awaiting requested review from yds05

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
June 2019 Release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chicm-ms @leckie-chn @QuanluZhang @SparkSnail @scarlett2018