Fix pipeline #1417
Merged
Fix pipeline #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull code
pull code
pull code
pull code
pull code
pull code
pull code
pull code
pull code
Run flake8 tests to find Python syntax errors and undefined names (#1…
pull code
pull code
chicm-ms
requested review from
SparkSnail,
liuzhe-lz,
QuanluZhang and
suiguoxin
QuanluZhang
approved these changes
Aug 6, 2019
liuzhe-lz
approved these changes
Aug 6, 2019
This was referenced Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
If config_test fails and metrics_test succeeded, the pipeline succeeded, since it only check exit code of last command in a script.
After fix:
If any of config_test and metrics_test fail, the entire pipeline fails.