Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve NNI manager logging #3624

Merged
merged 4 commits into from
May 12, 2021
Merged

Conversation

liuzhe-lz
Copy link
Contributor

This PR implements following improvements:

  1. Allow TS loggers to have "name" like Python counterpart, so it can distinguish log messages from different modules. This will be helpful for 3rd party training service.
  2. Correctly format log message to string (rather than array).
  3. Automatically stringify JSON objects and arrays, so you won't see [Object object] in log.

Before:

[2021-04-21 10:37:34] INFO [ 'Datastore initialization done' ]

Now:

[2021-05-10 12:07:56] INFO (root) Datastore initialization done

@ultmaster ultmaster added this to In progress in v2.3 via automation May 10, 2021
@ultmaster ultmaster added the enhancement New feature or request label May 10, 2021
@ultmaster ultmaster moved this from In progress to Reviewer approved in v2.3 May 10, 2021
@ultmaster ultmaster merged commit 290558c into microsoft:master May 12, 2021
v2.3 automation moved this from Reviewer approved to Done May 12, 2021
@liuzhe-lz liuzhe-lz deleted the managerlog branch June 17, 2021 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
v2.3
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants