Suport prefix url for nnimanager #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuzhe-lz
reviewed
May 14, 2021
| @@ -19,7 +20,7 @@ import { createRestHandler } from './restHandler'; | |||
| */ | |||
| @component.Singleton | |||
| export class NNIRestServer extends RestServer { | |||
| private readonly API_ROOT_URL: string = '/api/v1/nni'; | |||
| private readonly API_ROOT_URL: string = `/api/v1/nni/${getUrlPrefix()}`; | |||
There was a problem hiding this comment.
I think prefix URL should better override /api/v1/nni.
There was a problem hiding this comment.
The same opinion with @liuzhe-lz , in
nni/nni/tools/nnictl/url_utils.py
Line 10 in 5a71ce9
so that we don't need to modify too many internal interfaces.
3 tasks
J-shang
reviewed
May 17, 2021
nni/tools/nnictl/launcher.py
Outdated
| @@ -81,6 +81,10 @@ def start_rest_server(port, platform, mode, experiment_id, foreground=False, log | |||
| cmds += ['--log_level', log_level] | |||
| if foreground: | |||
| cmds += ['--foreground', 'true'] | |||
| if url_prefix: | |||
| path_validation(url_prefix) | |||
There was a problem hiding this comment.
maybe validate in create_experiment is better?
and if we resume or view an experiment, should we support reconfigure url_prefix?
There was a problem hiding this comment.
- Changed.
- I'm ok for that, since there is no way to change "url_prefix". Any concerns @liuzhe-lz ?
added 2 commits
May 17, 2021 14:27
liuzhe-lz
approved these changes
May 21, 2021
J-shang
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suport prefix url for nnimanager