Support nested ModuleList and fix an issue in list append #3652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
QuanluZhang
commented
May 19, 2021
•
QuanluZhang
commented
- support nested ModuleList
- fix an issue of in-place python list append: incorrect control flow
ultmaster
reviewed
May 19, 2021
| @@ -0,0 +1,72 @@ | |||
| import os | |||
There was a problem hiding this comment.
this file is committed before, it is supposed to test whole models. so I put this test into this file
ultmaster
approved these changes
May 20, 2021
liuzhe-lz
approved these changes
May 21, 2021
ultmaster
changed the title
49 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.