Change NNI manager IP detection method and remove netifaces dependency
#3860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-shang
approved these changes
Jun 23, 2021
SparkSnail
approved these changes
Jun 23, 2021
SparkSnail
added a commit
to SparkSnail/nni
that referenced
this pull request
Jul 8, 2021
This reverts commit 51c6afd.
SparkSnail
added a commit
to SparkSnail/nni
that referenced
this pull request
Jul 8, 2021
This reverts commit 6af2aa4.
SparkSnail
added a commit
to SparkSnail/nni
that referenced
this pull request
Jul 8, 2021
This reverts commit 6af2aa4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method will get the IP address of default router, which means, when anyone creates connection and sends packets via standard library, it will use this address.
The method is platform independent and is irrelative to "eth0", so at Python side it does not need
netifacesto do validation.